Guy Bedford

Results 1051 comments of Guy Bedford

Strictly speaking, the specifier being loaded in the module registry _is_ `npm:preact` in this case (and so far as it only has one representation in a given Deno application lifetime)....

@bakkot Wasm modules only support USV string imports, so that in the ESM integration not all specifiers would be compatible at a strictly theoretical level.

@michaelficarra this is mostly a correctness issue over there being a tangible use case, although it's difficult to predict if there might be some tangible use case in future. Specifically,...

@bakkot it sounds like an alternative might also be to pass the string through `toWellFormed` then?

To further enumerate some of the scenarios: * If setting a `resolveHook` but not a `loadHook`, would the resolution default to host module resolution? * If setting a `loadHook` but...

I guess we could create an `--instantiation hybrid` mode that calls the function, and if it returns a promise conditionally awaits it. Would gladly take a PR along those lines,...

Your solution looks exactly correct to me yeah, unless we entirely emit two instantiation wrappers - `instantiateAsync` and `instantiateSync` where you select which one to use at the top-level for...

Surely not more than a few hundred lines of JS? Or do you mean for the Rust code?

I put together an initial experiment here in https://github.com/bytecodealliance/jco/pull/413, thanks for the idea @bakkot. @whitequark I'm not completely sure of the exact use case, and I don't personally have any...

@dbaeumer we do have local name generation utility that handles deduping in https://github.com/bytecodealliance/jco/blob/main/crates/js-component-bindgen/src/names.rs. In the TS generation, we run all name generation through this deduping to get the local name...