elixir-pdf-generator icon indicating copy to clipboard operation
elixir-pdf-generator copied to clipboard

Published 20 hours ago • verified publisher icon gutschilla

Use new Supervisor syntax for elixir version >= 1.5

Open dlee-tt opened this issue 5 years ago • 5 comments

Hello,

I came across an issue where, after upgrading to elixir 1.11, I saw that pdf_generator.ex was still using the deprecated syntax for Supervisor.spec.worker.

I made the change to use the new child specification syntax that is applicable for elixir versions 1.5 and above.

If anything is out of place or not the best practice, I would really appreciate it if you let me know, as I'm a newbie in the open source/elixir world.

Thank you very much!

Dongkeun

dlee-tt avatar Oct 28 '20 18:10 dlee-tt

Hi @dlee-tt , thanks a bunch for your PR! I was very busy with private things and at work so sorry this module seemed like unmaintained :grimacing:

Right now, PdgGenerator only required Elixir 1.1 to work and thus relies on a quite a few very-style mechanics. I would assume there's not a lot of people out there still using such an old Elixir version but I am unsure if bumping the minimum required version to, let's say 1.5 is fine to everyone. Probably yes. What's your opinion on that?

gutschilla avatar Feb 02 '21 11:02 gutschilla

Hi @gutschilla,

Thank you for responding during a busy time!

In my opinion, it would be fine; as you mentioned, 1.1 is quite old at this point and I believe most users should have upgraded to version 1.5 or higher at this point in time. And if it forces some users to upgrade their Elixir version, I think it might be preferable to do it now than later, since eventually this would be inevitable.

dlee-tt avatar Feb 03 '21 23:02 dlee-tt

Elixir 1.15 was released in 2017. I think requiring ~> 1.15 should not be a problem for anyone at this point. Currently, even security fixes are only supported from 1.9.

https://hexdocs.pm/elixir/main/compatibility-and-deprecations.html

maennchen avatar May 30 '22 12:05 maennchen

Hi @gutschilla, can you please review the merge request again and release the changes? I'm using Elixir version 1.14 and I have this deprecation message

yoonwaiyan avatar Jul 14 '23 12:07 yoonwaiyan

@gutschilla I offer a suggestion: You can raise the minimum elixir version, merge this pr, bump the package to 2.0 and put the new elixir version as the breaking change in the release notes.

gangstead avatar Feb 01 '24 20:02 gangstead