elixir-pdf-generator icon indicating copy to clipboard operation
elixir-pdf-generator copied to clipboard

Added `prefer_local_executable: true` option so that users are able to install `chrome-headless-render-pdf` and `puppeteer` locally

Open ryanzidago opened this issue 5 years ago • 1 comments

For instance, in the context of a Phoenix application, users can now chose if they would rather install chrome-headless-render-pdf and puppeteer within the /assets/node_modules directory.

  • Having npm packages installed locally makes it easier to deploy an application to Heroku, where it is unrecommended to having them installed globally.

  • Furthermore, with this prefer_local_executable, users are not required to do complex manipulation with Makefile, granted that they do not use mix release.

  • The README.md was adapted to include the options, typos were fixed.

  • A test was written to check if the option works as intented.

ryanzidago avatar Jan 31 '20 14:01 ryanzidago

Hu @ryanzidago , thanks for the idea and implementation. I have have merged your code here as a result: https://github.com/gutschilla/elixir-pdf-generator/pull/82

gutschilla avatar Feb 02 '21 12:02 gutschilla