tsc-files icon indicating copy to clipboard operation
tsc-files copied to clipboard

Published 20 hours ago • verified publisher icon gustavopch

Attach cleanup listeners to ensure the temp file is cleaned up properly

Open resolritter opened this issue 3 years ago • 4 comments

close #27

resolritter avatar Mar 20 '22 15:03 resolritter

@resolritter Thanks for the PR. I want to make some code-style changes. Can you enable edits? https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork

gustavopch avatar Mar 20 '22 15:03 gustavopch

@gustavopch done

resolritter avatar Mar 20 '22 18:03 resolritter

Any progress on this?

didaktio avatar May 16 '22 16:05 didaktio

@didaktio I'm really sorry, but I'm not having time to dedicate to this repo as I'm already overwhelmed with work stuff, and I'm not even using TypeScript these days. I also don't think merging without testing would be a good idea as it could create still more maintenance needs in case it breaks something. The whole thing is less than 100 LoC, so I encourage people to fork or maybe just copy the code into their projects and adapt as needed.

gustavopch avatar May 20 '22 14:05 gustavopch

Implemented in https://github.com/gustavopch/tsc-files/releases/tag/v1.1.4. Thanks for the PR and sorry for the delay.

gustavopch avatar Jul 04 '23 13:07 gustavopch