rocketchat-jira-trigger
rocketchat-jira-trigger copied to clipboard
Ignore edits
There is probably a way to reuse more of the AppIntegrationTest without copying, but I wasn't sure how.
I would have liked the test to validate the response but I am not sure I understand how everything (validators specifically) links together. Some testing on a chat instance shows the desired behavior. On new messages containing a valid jira issue, the link is sent back. On edit of a message containing or having a valid jira issue added, no response is sent back.
Codecov Report
Merging #68 into master will decrease coverage by
3.59%. The diff coverage is88.88%.
@@ Coverage Diff @@
## master #68 +/- ##
===========================================
- Coverage 88.12% 84.52% -3.6%
- Complexity 208 209 +1
===========================================
Files 39 40 +1
Lines 522 530 +8
Branches 35 36 +1
===========================================
- Hits 460 448 -12
- Misses 40 62 +22
+ Partials 22 20 -2
| Impacted Files | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| ...trigger/configuration/RocketChatConfiguration.java | 100% <100%> (ø) |
8 <1> (+1) |
:arrow_up: |
| ...chat/jira_trigger/validation/ValidationModule.java | 100% <100%> (ø) |
8 <2> (+1) |
:arrow_up: |
| ...ketchat/jira_trigger/validation/EditValidator.java | 80% <80%> (ø) |
2 <2> (?) |
|
| ...cketchat/jira_trigger/routes/DetectIssueRoute.java | 26.66% <0%> (-42.23%) |
4% <0%> (-3%) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 2cd5c22...a30720c. Read the comment docs.