suru-plus-aspromauros icon indicating copy to clipboard operation
suru-plus-aspromauros copied to clipboard

Published 20 hours ago • verified publisher icon gusbemacbe

Icons missing "?" in Elisa

Open Roboron3042 opened this issue 5 years ago • 4 comments

First and foremost, thank you very much for cyberpunkneoning this theme, it's SUPERB. I'm enjoying it very much.

Second, I've been using it system-wide and i have found some icons are missing in Elisa music player (even some basic icons like the "song" icon I'm sure this theme has... weird).

Here is a comparative between Papirus-Dark icons and Suru++ Asprómauros icons in Elisa.

Papirus Suru++ Papirus Suru++

Again, thank you for your work ^.^

Roboron3042 avatar Jun 05 '19 11:06 Roboron3042

I have just fixed Oomox issue and also fixed more or less than 200 icons which did not have exactly fill="currentColor" class="ColorScheme-Text", causing them to be gone. I will test on Elisa.

gusbemacbe avatar Jun 05 '19 18:06 gusbemacbe

It seems that it does not have certain icons of Elisa, I will investigate why these icons are not rendered correctly:

image

gusbemacbe avatar Jun 05 '19 18:06 gusbemacbe

Strange, Suru++ Asprómauros has this icon, but not rendered correctly in Elisa:

image

@SmartFinn, is this icon name exactly favorite-genres-amarok.svg?

gusbemacbe avatar Jun 05 '19 18:06 gusbemacbe

Hello @SmartFinn and @Roboron3042 !

I found the icons names:

https://github.com/KDE/elisa/blob/7dbdbc31c20a467b030e8a1dc751926a43fdeffc/src/models/viewsmodel.cpp#L53-L60

I searched all these icons names in Papirus and in Suru++, all they are not present, except amarok_playcount, view-media-artist, view-media-playlist and document-open-folder.

image

gusbemacbe avatar Jun 05 '19 20:06 gusbemacbe