hugo-profile icon indicating copy to clipboard operation
hugo-profile copied to clipboard

Sticky navbar

Open LITUATUI opened this issue 1 year ago • 4 comments

Please add the option to make the navbar sticky, or make it default.

Thanks!

LITUATUI avatar Feb 04 '23 03:02 LITUATUI

https://github.com/gurusabarish/hugo-profile/pull/100

pantera-rosa avatar Feb 07 '23 22:02 pantera-rosa

Hey @pantera-rosa / @benarmstead , when running this on:

$ hugo version                                                                                                                                                                      [13:36:06]
hugo v0.121.1-00b46fed8e47f7bb0a85d7cfc2d9f1356379b740+extended darwin/arm64 BuildDate=2023-12-08T08:47:45Z VendorInfo=brew

I have noticed that the navbar is not sticky on scroll down with the yaml configuration enabled, but instantly appears on a single pixel when scrolling up. It seems like this is not working as intended?

https://github.com/gurusabarish/hugo-profile/assets/4028612/7431d9a2-dee0-4115-97ff-0d62ae3aef71

It seems like the class is not being set on initial load, but shows up afterwards?

Screenshot 2023-12-24 at 1 43 46 PM Screenshot 2023-12-24 at 1 43 50 PM

delize avatar Dec 24 '23 19:12 delize

It seems like you used a custom class rather than using the default Bootstrap class of fixed-top?

delize avatar Dec 24 '23 19:12 delize

Apologies, looking back at git blame, your original PR had the correct class. Commenting on in #100 about the issue.

delize avatar Dec 24 '23 19:12 delize