hugo-profile icon indicating copy to clipboard operation
hugo-profile copied to clipboard

Multiple jobs in one company (with some minor improvements over PR #163)

Open CarlosSanabriaM opened this issue 1 year ago • 3 comments

This PR basically contains the same changes done by @hgokduman in PR #163, but with some minor improvements and fixes. I think it's better to merge this one instead.

All the credits to @hgokduman for the awesome work. I just applied some minor changes.

CarlosSanabriaM avatar Nov 09 '24 10:11 CarlosSanabriaM

There are three different PRs for the same thing, would it be possible for us as a community to choose one (or merge features of all) to make it easier to work towards a solution:

https://github.com/gurusabarish/hugo-profile/pull/203 https://github.com/gurusabarish/hugo-profile/pull/192 https://github.com/gurusabarish/hugo-profile/pull/163

delize avatar Jan 20 '25 20:01 delize

@delize do you see any downsides in my current implementation?

CarlosSanabriaM avatar Jan 29 '25 17:01 CarlosSanabriaM

Hey, sorry for the delay.

I don't necessarily see downsides, but, harder for me to test at the moment.

I think the three things for me are (if it's a similar - [ ] copy as to the other PR mentioned):

  1. Not ever additional kob title needs a company attached to it

  2. Bullet / Header use needs to be aligned from a UX perspective. Using H2 for the entire setup looks odd to me

  3. Having a root company and then sub-titles vs root company and sub orgs. This is dependent on contractor vs non-contractor jobs I think.

Sorry, can't fully flesh those ideas out at the moment.

delize avatar Feb 04 '25 09:02 delize

supported provided - https://github.com/gurusabarish/hugo-profile/commit/33e5afcbc5f0037a90c988423abc7c0dc308ae93

gurusabarish avatar Oct 06 '25 09:10 gurusabarish