litiengine icon indicating copy to clipboard operation
litiengine copied to clipboard

Remove ParticleParameters

Open nightm4re94 opened this issue 2 years ago • 1 comments

What feature / which classes are you referring to? ParticleParameter.

Describe what could be enhanced. Instead of using ParticleParameters for Emitter configuration, we could slim down our API by using Attributes. Attributes are generic and offer more flexibility and in my opinion having two components with nearly identical functionality doesn't make sense.

Are there any alternatives to what you've considered? Please elaborate. If we see a need to keep ParticleParameters specifically, we should document the difference properly.

Additional thoughts Removing ParticleParameters would entail these changes:

  • [ ] make Attributes serializable
  • [ ] adjust Emitters to use Attributes instead of ParticleParameter
  • [ ] Rename EmitterData to EmitterAttributes
  • [ ] provide a detailed migration guide for existing projects since this is a breaking change.

nightm4re94 avatar Aug 12 '22 11:08 nightm4re94

I got really lost here. Would appreciate if at somepoint someone could help me finish my branch.

nightm4re94 avatar Mar 25 '24 17:03 nightm4re94