litiengine icon indicating copy to clipboard operation
litiengine copied to clipboard

Published 20 hours ago • verified publisher icon gurkenlabs

Typo fixes

Open mathieu-fanduel opened this issue 3 years ago • 5 comments

mathieu-fanduel avatar Jan 25 '22 00:01 mathieu-fanduel

Hi, just checking in if this PR is still in draft state or ready for review? cheers!

nightm4re94 avatar Feb 06 '22 12:02 nightm4re94

Actually it could be reviewed , these are some hopefully minimal changes ( fixing typo ) to get my teeth in the code base and review process

mathieu-fanduel avatar Feb 07 '22 08:02 mathieu-fanduel

Hi, sorry this is taking longer than usual. We're on a sort of break from LITIENGINE due to heavy workload currently. What I can say however is that we would prefer PullRequests that are separated into different topics, for example:

  • one for fixing typos
  • one for proposing Entity opacity
  • one for Java 17 refactorings This speeds up reviews and lets us merge parts even if other parts need revisions.

nightm4re94 avatar Feb 20 '22 12:02 nightm4re94

Cool I will do that

mathieu-fanduel avatar Feb 20 '22 18:02 mathieu-fanduel

Hi there, just checking in whether you're still interested in splitting this PR up into three separate ones. That would facilitate the review greatly.

nightm4re94 avatar Jun 24 '22 22:06 nightm4re94

Closing this due to inactivity. Thank you and feel free to resume at a later point :)

nightm4re94 avatar Dec 15 '22 21:12 nightm4re94