DDGI icon indicating copy to clipboard operation
DDGI copied to clipboard

Published 20 hours ago • verified publisher icon guoxx

Problem for moment2

Open zq317157782 opened this issue 5 years ago • 2 comments

psOut.distMoments.x /= distWeightSum; psOut.distMoments.y = psOut.distMoments.x * psOut.distMoments.x; the moment2 is calculated by the square of moment1,but it should be the mean of the square.

zq317157782 avatar Jan 16 '20 07:01 zq317157782

@zq317157782 thank you for point out the issue. I submit the fix in rev https://github.com/guoxx/DDGI/commit/cc8b6b8194ff4473cdf21f72754a103cd6f8526d.

However I didn't use pre-filterred irradiance at the end, applying visibility test didn't achieve promising result in my scene setup, and it introduce artifacts like light leaking as filterable shadow map. Please let me know if you made any progress on this part.

guoxx avatar Jan 16 '20 16:01 guoxx

Light leaking is always introduced if just use Chebyshev's Inequality, I'm also finding a method to progress on light leaking but until now I can't find a good method. Maybe use other shadowmap's method like ESM can help it.

zq317157782 avatar Feb 07 '20 02:02 zq317157782