PFLD icon indicating copy to clipboard operation
PFLD copied to clipboard

degrees or radians?

Open renderless opened this issue 5 years ago • 4 comments

calculate_pitch_yaw_roll returns head pose in degrees but tf.cos() receive radians. will this be an issue?

renderless avatar Oct 23 '19 04:10 renderless

calculate_pitch_yaw_roll -> degrees tf.cos(radians ) But I don't think it has any effect.

ideask avatar Nov 23 '19 15:11 ideask

I think it is ok to just keep the output of calculate_pitch_yaw_roll and the input of tf.cos in the same unit, in spite of whether the unit is degree or radian.Of course it's better to use radians

sljlp avatar Dec 04 '19 05:12 sljlp

I think it is ok to just keep the output of calculate_pitch_yaw_roll and the input of tf.cos in the same unit, in spite of whether the unit is degree or radian.Of course it's better to use radians

even if use radians, still there might be some problem with the cos function , like cos(abs(0.6-0.5))= cos(abs(0.6-(0.5+2*pi))), the problem would be more serious using degree i guess

wyfdodogod avatar Feb 15 '23 11:02 wyfdodogod

maybe the angle needs to be normalized before computing

sljlp avatar Feb 15 '23 11:02 sljlp