Gunter Spranz

Results 57 comments of Gunter Spranz

It seems to have to do something with @graphql-tools/executor-http I have a 'global' route where I just serve a schema with Yoga. This route does use a different AbortController for...

I tried to reproduce the problem in a minimal server, so I modified yoga-server.ts like this: ``` import { buildHTTPExecutor } from '@graphql-tools/executor-http'; import { stitchSchemas } from '@graphql-tools/stitch'; import...

Btw, even the gold standard for gprc proxy envoy had this problem before: https://github.com/triton-inference-server/server/issues/6936

Possible solutions I see: - remove TE header from the list in stripHttp1ConnectionHeaders - make rewriteRequestHeaders happen after stripHttp1ConnectionHeaders

@mcollina: So a PR which just removes TE from the stripped connection headers and a regression test which makes sure that it doesn´t get removed anymore would be sufficient?

I think it was just an oversight in the original implementation. `transfer-encoding` and `te` are on subsequent lines in the case in stripHttp1ConnectionHeaders. After a little research I came up...

I found this place in the Node.js http2 module: [isIllegalConnectionSpecificHeader](https://github.com/nodejs/node/blob/72c0fdf125314145e6ddef3543965ee63227542f/lib/internal/http2/util.js#L583) So TE headers are not illegal for HTTP/2 requests if the value is 'trailers' I've created a pull request now:...