grunt-manifest icon indicating copy to clipboard operation
grunt-manifest copied to clipboard

Fallback encodeURI

Open olddevyg opened this issue 9 years ago • 5 comments

Hi, I have an issue with the "fallback" option. You encode the given strings which leads to a "my-file.ab fb/my-file.ab" generated as "my-file.ab%20fb/my-file.ab". And that doesn't work with the cache manifest.

I fixed it by simply removing the encodeURI(). But it only works because my paths are clean.

olddevyg avatar Jan 21 '16 10:01 olddevyg

:+1:

Even a fairly standard fallback section such as / /index.html renders as /%20/index.html.

delucis avatar Feb 05 '16 01:02 delucis

Oh, just noticed this was patched by #59, but I guess is not yet in the version 0.4.4 distributed over npm.

delucis avatar Feb 05 '16 01:02 delucis

Are you guys adding it to the npm dist?

aldoshin avatar Apr 12 '16 21:04 aldoshin

is there already a plan when to release a new version with the fix? 0.4.4. still has spaces.

fischermatte avatar Jul 01 '16 08:07 fischermatte

Any news on releasing the fix for this? I can see it has already been patched, just not released.

samanabo avatar Apr 29 '17 14:04 samanabo