1brc icon indicating copy to clipboard operation
1brc copied to clipboard

Basic Implementation with Memory Mapped File, SIMD Search

Open gamlerhart opened this issue 2 years ago • 3 comments

Check List:

  • [x] Tests pass (./test.sh <username> shows no differences between expected and actual outputs)
  • [x] All formatting changes by the build are committed
  • [x] Your launch script is named calculate_average_<username>.sh (make sure to match casing of your GH user name) and is executable
  • [x] Output matches that of calculate_average_baseline.sh
  • Execution time: 0m49.188s
  • Execution time of reference implementation: 3m52.729s

gamlerhart avatar Jan 10 '24 20:01 gamlerhart

Implementation class: dev.morling.onebrc.CalculateAverage_gamlerhart

Runtime on my laptop: 50-60 seconds: 6 core/12 hyperthreads: i7-9750H CPU @ 2.60GHz, 32GByte Memory.

Note: Implementation is single threaded at the moment.

gamlerhart avatar Jan 10 '24 20:01 gamlerhart

I'm not sure what the task All formatting changes by the build are committed refers to?

gamlerhart avatar Jan 10 '24 20:01 gamlerhart

I'm not sure what the task All formatting changes by the build are committed refers to?

Hi there, I can help out with this.

When you build this repo with Maven: ./mvnw clean verify one of the tasks that runs is a formatter, which applies certain rules to your code to make it look consistent. Things like indentation, spacing, and new line rules.

The author just wants you to include these formatting changes in your PR. Which just means make sure you build before submitting.

MeanderingProgrammer avatar Jan 10 '24 21:01 MeanderingProgrammer

00:59.901. Nice to see the SIMD stuff. Thx for participating!

gunnarmorling avatar Jan 11 '24 10:01 gunnarmorling

Well, it also triggered two bug reports (1, 2) to the JDK I encountered. And I've learned some stuff.

There is certainly a lot room for improvement =).

gamlerhart avatar Jan 11 '24 12:01 gamlerhart