Christian Gunderman
Christian Gunderman
I don't have to much familiarity with this area unless it's TextMate snippets. Aditya (adityk) is probably the most up to date. I'll ping him and ask for a Github...
I think Aditya has been occupied with another investigation. Can you please file an issue on Developer Community so this gets more attention? +@olegtk in case he has any ideas.
I was thinking specifically of this: https://github.com/microsoft/vs-streamjsonrpc/blob/716e9179a9895cd617b0c07046797578f450cc81/doc/disconnecting.md > [When] the JsonRpc.Dispose method is invoked ... [JsonRpc] faults all outstanding Task objects that represent outbound requests with a ConnectionLostException.
Hey @StellaHuang95, FYI I believe I have a fix for this issue: https://devdiv.visualstudio.com/DevDiv/_git/VSLanguageServerClient/pullrequest/422648
@HJLebbink can you share a repro project?
Great, thanks! I'll take a look soon.
+@DanteGagne our accessibility expert
One thing I think is cause for concern is how we choose whether or not the new completion API is supported. > IAsyncCompletionBroker.IsCompletionSupported checks if there are any IAsyncCompletionSourceProviders and...
> always finish before running any other types of requests Do you mean [this](https://github.com/dotnet/razor-tooling/blob/60e09d26fdfc921af25e3dad94b0ffbcd6494d01/src/Razor/src/Microsoft.AspNetCore.Razor.LanguageServer/JsonRpc/JsonRpcRequestScheduler.cs#L59-L67) function? It looks like it properly waits when executing _a serial, then parallel_ request, but AFAICT...
FYI: Thanks to a repro from the great folks on the debugger team, I did end up finding a race condition on the LSP client side where in extremely obscure...