gun-level icon indicating copy to clipboard operation
gun-level copied to clipboard

Failing test

Open NorikDavtian opened this issue 7 years ago • 4 comments

  ․․․․․․․․․․!․․

  12 passing (504ms)
  1 failing

  1) Gun using level should merge with existing data:
     Uncaught Error: Expected { _: { '#': 'gkww0wuvad6', '>': { success: 1520904130506 } }, success: true } to include { success: true, data: true }
      at assert (node_modules/expect/lib/assert.js:29:9)

on src/spec.js:87 changing the makeGun() to the glogbal gun variable fixes the issue, but not sure if that's the right behavior or not? or this is an async issue?!

NorikDavtian avatar Mar 13 '18 02:03 NorikDavtian

@NorikDavtian welcome!!! :)

That particular test we found out is actually non-deterministic (if you re-run a couple times it will occasionally pass). I didn't write the code, so I would need to sit down and go through it.

My plan is to probably deprecate the existing code, swap in the Radix Storage Engine (which is what S3 and other adapters use) instead, and then use Level on that. However this is pretty low priority.

I noticed you are at dollarshaveclub though - would love to hear about any potential use case for gun there? If it requires Level, maybe I could bump the priority up!

amark avatar Mar 15 '18 02:03 amark

Thanks @amark , that was my understanding of what was happening there. Currently just exploring different data transfer, transform, and storage strategies. Just stumbled on this and wanted to give it a try. We have a wide variety of use cases that we look for creative ways to solve. Good to have options :)

NorikDavtian avatar Mar 16 '18 20:03 NorikDavtian

@NorikDavtian what would be needed to do a PoC for you guys? :)

amark avatar Mar 22 '18 22:03 amark

@amark I will dm you on gitter if anything notable comes along to collaborate on a PoC.

NorikDavtian avatar Mar 23 '18 00:03 NorikDavtian