build123d icon indicating copy to clipboard operation
build123d copied to clipboard

Review the Location constructor and optimize the valid overloads

Open gumyr opened this issue 2 years ago • 1 comments

Some of the Location constructor's overloads seem confusing and may not be optimal. Specifically,

    @overload
    def __init__(
        self, translation: VectorLike, direction: VectorLike, angle: float
    ):

seems misleading at best. The term translation and direction should also be reconsidered as there are position and orientation properties.

gumyr avatar Dec 20 '23 16:12 gumyr

kwargs are currently not working in Location either Location((1,2,3),rotation=(10,20,30)) returns TypeError: Location.__init__() got an unexpected keyword argument 'rotation'

jdegenstein avatar Mar 24 '24 20:03 jdegenstein