PunycodeSwift icon indicating copy to clipboard operation
PunycodeSwift copied to clipboard

Typo in package name?

Open mxcl opened this issue 4 years ago • 2 comments

The main product is defined as Punnycode in the Package.swift. This made figuring out how to install it tricky.

mxcl avatar Mar 10 '21 16:03 mxcl

For others that ran into the same issue, this is what you have to do to depend on this package:

pkg.dependencies.append(.package(name: "Punycode", url: "https://github.com/gumob/PunycodeSwift", from: "2.0.0"))
pkg.targets.append(.target(
    name: "foo",
    dependencies: [
        .product(name: "Punnycode", package: "Punycode")
    ]))

mxcl avatar Mar 10 '21 16:03 mxcl

I just ran into this as well.

@gumob would you consider updating the Package Name here?

case avatar Sep 13 '23 17:09 case

@gumob That's in theory BCH now, I was just trying to update my packages which failed as it couldn't find the package anymore.

Edit: Actually as long as https://github.com/gumob/TLDExtractSwift isn't updated as well, it's a BCH

HolzmannDaniel avatar Aug 22 '24 15:08 HolzmannDaniel

I see this rename was just completed. For future reference, renaming a package should probably be a major version bump, since it breaks SPM's ability to resolve. I've opened a PR to resolve the issue in TLDExtract, but you could consider reverting the naming change (as 2.1.2) and then re-implementing it along with a major version bump (3.0.0).

tremblay avatar Aug 22 '24 17:08 tremblay

I am currently in the process of updating PunycodeSwift to the latest version, and we plan to update TLDExtractSwift in the near future as well.

For now, I have merged the PR, but if you encounter any build failures, please leave a comment, and I will roll back PunycodeSwift.

gumob avatar Aug 23 '24 01:08 gumob