php-image-resize icon indicating copy to clipboard operation
php-image-resize copied to clipboard

Chaining doesn't seem to retain original image

Open G2G2G2G opened this issue 3 years ago • 4 comments

Code doesn't really matter since the example in the readme does the same thing, but you can see it produces an extremely dark version, other than making it really dark it seems to have the rest of the quality intact.. (does this with all images)

        $image = ImageResize::createFromString(base64_decode($image_data_base64));
        $image->crop(200, 200)
        ->save($destination . $time . '_s.jpg', IMAGETYPE_JPEG)
        ->resizeToLongSide(1300)
        ->save($destination . $time . '_b.jpg', IMAGETYPE_JPEG);

1

not using chaining at all produces fine images.

G2G2G2G avatar Mar 23 '21 00:03 G2G2G2G

It seems to be same as PR #163.

I try to organize the for v2 and still wait for @adityapatadia reponse.

peter279k avatar Mar 23 '21 03:03 peter279k

@G2G2G2G , maintainers of gumlet/php-image-resize rejected any changes or pull requests from me about V2 (see closed PR)

You can use my package: ajur-media/php-image-resize

KarelWintersky avatar Jul 13 '21 19:07 KarelWintersky

Sorry. I'm busy at the recent time. And I need to figure out the current way to integrate your PR #163.

Sorry for my delay response.

peter279k avatar Jul 13 '21 23:07 peter279k

Average ONE YEAR, LOL....

KarelWintersky avatar Jul 14 '21 15:07 KarelWintersky

I am still ready to accept smaller PR to get this fixed.

adityapatadia avatar Oct 11 '23 14:10 adityapatadia

https://github.com/gumlet/php-image-resize/pull/163

You delayed the process of reviewing my code for so long, and then made so many ridiculous and meaningless demands (by refusing to provide the linter configuration or a document about YOUR codestyle), that I lost all desire to help you fix errors in YOUR library.

You couldn't find time for more than two months to review changes that clearly improved the performance of your code and fixed many problems.

After that you made a lot of ridiculous claims about my work: “extra lines”, “extra spaces”, and so on and so forth.

Sorry, but I don't feel like investing in your library anymore. I corrected all the mistakes that you made during its development and released my own based on your code according to the license you specified.

You can use my code in your projects.

KarelWintersky avatar Oct 12 '23 00:10 KarelWintersky