filesystem icon indicating copy to clipboard operation
filesystem copied to clipboard
verified publisher icon gulrak

Fix building on Windows with MSYS2

Open 500-internal-server-error opened this issue 10 months ago • 0 comments

This PR:

  • fixes building on Windows with MSYS2 UCRT64 GCC (adds -mbig-obj to CXXFLAGS by default for MinGW in general, instead of just Cygwin)
  • fixes building on Windows with MSYS2 CLANG64 Clang (modifies the #ifdefss around the GCC #pragmas to also work for Clang, and adds more to fix the things Clang catches that GCC doesn't)
  • adds MSYS2 to CI

Tests against std::filesystem remain broken, and must be disabled using -DGHC_FILESYSTEM_BUILD_STD_TEST=NO, but at least -DCMAKE_CXX_FLAGS=-Wa,-mbig-obj is no longer required to be passed explicitly.

If any of the above are undesirable, it can be reverted and/or added in a separate PR.

Fixes https://github.com/gulrak/filesystem/issues/189

500-internal-server-error avatar Feb 19 '25 15:02 500-internal-server-error