liftoff icon indicating copy to clipboard operation
liftoff copied to clipboard

Add docs for extension {module, register()} variant

Open cspotcode opened this issue 8 years ago • 3 comments

It'd be cool if the documentation mentions this variant of extensions:

extensions: {
    ".foo" {
        module: "foo-loader", // load this module
        register: (fooLoader) { // pass it to this function
            fooLoader.register();
        }
    }
}

I see that it's already explained in js-interpret's readme so even linking there, but specifically in relation to the above syntax, would be helpful for newcomers.

cspotcode avatar Jun 21 '16 21:06 cspotcode

Surfacing the docs from dependencies has been a big problem for us. All of it has to be done manually right now. If you'd like to send a PR, I'm willing to review it.

phated avatar Jun 21 '16 22:06 phated

I won't have time for a PR in the next few months; busy with work stuff.

On Tue, Jun 21, 2016 at 6:07 PM, Blaine Bublitz [email protected] wrote:

Surfacing the docs from dependencies has been a big problem for us. All of it has to be done manually right now. If you'd like to send a PR, I'm willing to review it.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/js-cli/js-liftoff/issues/74#issuecomment-227587321, or mute the thread https://github.com/notifications/unsubscribe/AAW-uNo8l4v0_FtUwyqCfabBT6cCsB0kks5qOGC_gaJpZM4I7Nxy .

cspotcode avatar Jun 23 '16 17:06 cspotcode

Same for all us maintainers. Feel free to submit a PR whenever you can.

phated avatar Jun 23 '16 17:06 phated