gulpjs.github.io icon indicating copy to clipboard operation
gulpjs.github.io copied to clipboard

Vinyl instance property table looks pretty bad

Open phated opened this issue 7 years ago • 4 comments

The way we have styling defined to have all the other tables looking good (on desktop and mobile) is causing the Instance Property table in Vinyl documentation to look really bad. It'd be nice to fix it in that one case but still keep the others the same.

phated avatar Oct 25 '18 21:10 phated

@phated I would be very grateful if you can throw more light on this issue

attaradev avatar Jan 01 '19 09:01 attaradev

@mikeattara the spacing for this table (https://gulpjs.com/docs/en/api/vinyl#instance-properties) doesn't look good. The description column doesn't get enough space while the throw column gets too much. I don't think we can target that table specifically without causing issues with the other tables.

phated avatar Jan 02 '19 20:01 phated

@phated I am new to open source contribution, i tried a few ways to target the table intended, but was unsuccessful. I have a very naive solution, if that doesn't affect the ideology or views through which the documentation was created, where we can just swap those two columns, to make it much better. Any ideas on this or anything that you think of.

APatil010 avatar Sep 19 '19 18:09 APatil010

@APatil010 with our new website upgrades, MDX is supported in all the documentation. We've already leverage this for https://raw.githubusercontent.com/gulpjs/gulp/master/docs/support/for-enterprise.md by adding custom classes to the code that is then styled on our website.

If you want to take another stab at this, feel free!

phated avatar Apr 23 '20 03:04 phated