gulp-cli icon indicating copy to clipboard operation
gulp-cli copied to clipboard

Use theming-log for logging.

Open sttk opened this issue 6 years ago • 11 comments

I've implemented configurable logs with theming-log.

But it is needed js-liftoff#95 to configure logs for require flag and completion flag.

sttk avatar Apr 16 '18 15:04 sttk

I updated this pr based on the current master branch.

sttk avatar Jun 10 '19 12:06 sttk

I've modified the above two points about document.

sttk avatar Jun 12 '19 13:06 sttk

This is a sample:

$ cat .gulp.js
module.exports = {
  log: {
    theme: require('./my-theme'),
    messages: require('./my-msgs'),
  }
};
$ cat my-theme.json 
{
  "ICON": "🥤",
  "VERSION": "{bold: {magenta: {1}}}",
  "TIMESTAMP": "{yellow: [{NOW: YYYY/MM/DD HH:mm:ss}]} ",
  "DESC": "{cyan: {1}}"
}
$ cat my-msgs.json 
{
  "info": {
    "version": "{ICON} {DESC: Gulp version}: {VERSION: {2}}\n{ICON} {DESC: CLI version}: {VERSION: {1}}"
  },
  "error": {
    "gulpfileNotFound": "{ICON} {TIMESTAMP}{ERROR: No gulpfile found}"
  }
}

gulp_theming_log

sttk avatar Jun 12 '19 14:06 sttk

@sttk I'd like to start work on this again. I noticed the HTML files in this PR - what are those used for?

phated avatar May 20 '20 06:05 phated

@phated Thanks. HTML files (and other files in docs/html) are sample documents to configure themes and messages. It's not necessary and use as refernece of Gulp document.

sttk avatar May 20 '20 11:05 sttk

@phated I created a new branch in my repository, which was based on the current master (v2.2.1), was merged with the change of this PR except doc/html, and was modified for #177.

https://github.com/sttk/gulp-cli/tree/use_theming-log_2

Should I update this PR with that new branch?

sttk avatar May 20 '20 16:05 sttk

@sttk Yes, please update this branch. It needed a rebase on master anyway.

I hope to find time to review soon.

phated avatar May 20 '20 16:05 phated

@sttk would you want to include your gulp libraries inside the gulpjs organization?

phated avatar May 20 '20 16:05 phated

@phated I've updated!

would you want to include your gulp libraries inside the gulpjs organization?

Yeah, it's good. I'd like to include copy-props, each-props and theming-log into gulp organization.

sttk avatar May 20 '20 23:05 sttk

I forgot to test about #177, and did it.

sttk avatar May 21 '20 02:05 sttk

@sttk thank you! I have confirmed that gulpjs members can create and transfer repositories, so you can transfer those projects when you have time.

phated avatar May 21 '20 03:05 phated

@sttk I believe this needs conflicts resolved since I merged #239

phated avatar Jan 07 '24 20:01 phated

@sttk are you planning to bring this up-to-date for the gulp-cli v3.0.0 release or should I plan to finish the remaining tasks without color configuration?

phated avatar Feb 07 '24 00:02 phated

@phated I'm tackling this issue. Hopefully, I'll finish this weekend. I hope to include this feature into gulp-cli v3.0.0. Please give me a little more time.

https://github.com/sttk/gulp-cli/commits/ci-test/

sttk avatar Feb 08 '24 03:02 sttk

@sttk 👍 sounds good. I will wait for your changes.

phated avatar Feb 09 '24 05:02 phated

@phated I've completed the changes for this PR. Please review it.

sttk avatar Feb 12 '24 03:02 sttk

I've added handling for yargs error message.

sttk avatar Feb 12 '24 08:02 sttk

I've made several changes. In Addition, I've removed config.description as its purpose overlaps with config.log.msgs.tasks/tasksJson.description.

sttk avatar Feb 12 '24 16:02 sttk

@phated I've modified what you pointed out except some points still under discussion.

sttk avatar Feb 17 '24 07:02 sttk

@phated I want to add --no-theme cli flag and flags.noTheme config flag that are not to use log theme and messages in a config file. I believe they could be useful when reporting issues or when not using the theme specified in the project.

Can I add them to this PR?

sttk avatar Mar 06 '24 12:03 sttk