avnc icon indicating copy to clipboard operation
avnc copied to clipboard

Enhancement idea: option to show toolbar (permanently?) on top/bottom in portrait mode

Open PureIncompetence opened this issue 2 years ago • 2 comments

In my opinion the wording for current options on where to align the toolbar (start/end) aren't optimal, left/right might be be more comprehensible. Additionally it might be useful for portrait mode to align the toolbar to the bottom of the screen, especially if the content isn't zoomed in enough to fill 100% of the screen. (I'll attach a screenhot to show what I mean.) screenshot_toolbar_top+bottom

Using this space for the toolbar would enable it to stay there permanently, even while controlling the remote system, which might be more convenient to use, as it wouldn't be necessary to use a gesture each time you need the keyboard or extra keys.

Another possibillity to show the toolbar permanently would be making it semi-transparent (being 100% visible if it wouldn't cover any of the remote screen's content and becoming e.g. 30% or 50% visible if it otherwise would). In my eyes this would be the preferred solution, even though having the toolbar at the bottom in portrait mode might still be neat from an ergonomy perspective (easier to reach with the thumb).

PureIncompetence avatar May 06 '22 18:05 PureIncompetence

In my opinion the wording for current options on where to align the toolbar (start/end) aren't optimal, left/right might be be more comprehensible.

This is a result of me trying to be "technically correct". When alignment is 'Start', toolbar will align with left-edge for LTR languages like English, while it will align with right-edge when in RTL mode, e.g. with Persian. We can force the left-right alignment irrespective of the layout mode, but I tried to be consistent with other UI elements.

As for the top-bottom toolbar position, it is not possible with current code. Toolbar is currently implemented using DrawerLayout, like the one on home page of AVNC. DrawerLayout handles toolbar visibility, animation and gesture detection. Unfortunately, it only supports left/right alignment.

I will look into other possible solutions for this, but I can't promise anything.

PS: Sorry for late reply.

gujjwal00 avatar Jun 06 '22 17:06 gujjwal00

When alignment is 'Start', toolbar will align with left-edge for LTR languages like English, while it will align with right-edge when in RTL mode, e.g. with Persian.

This is actually very thoughtful and something I didnt have on my mind, as I only speak / write LTR languages. In that case it probably makes more sense this way. To me it wasn't obvious while first going through the settings, but I don't know if I can generalize from myself to others in this regard.

Regarding the top-bottom option: It would be nice to have but it is probably far from necessary and most likely just something I will get used to. As an alternative idea which might not require that much rewriting: Does DrawerLayout allow to set the height on which one needs to swipe sideways (e.g. to swipe in the upper, mid or lower third of the screen sideways)? Right now it only seems to react when I swipe left in the mid third of the screen.

PS: Sorry for late reply.

No need to. You're doing this in your spare time and owe us nothing. Right now you don't even ask for donations on the project page. It is totally up to you, when and how much time you want to invest into this project.

PureIncompetence avatar Jun 06 '22 19:06 PureIncompetence

The main reason for this proposal was the unused space on top / bottom depending on the current zoom state. As there is now the very handy option to set a default zoom per connection (and even per orientation), I've got no more unused space above / underneath the remote connection content. Therefore I'll close close this issue now.

PureIncompetence avatar Dec 21 '22 06:12 PureIncompetence