Guillaume Abrioux

> Can I pester you into moving more of the code into a function in cephadmlib somewhere? I'd like to continue shrinking cephadm.py whenever possible, and this looks like a...

jenkins test api

jenkins test windows

https://pulpito.ceph.com/gabrioux-2024-06-12_06:41:10-orch:cephadm-wip-guits-main-2024-06-11-1557-distro-default-smithi/

hi @boyvinall sorry for the delay, and thanks for your contribution! A couple of comments: - Nit: This is purely cosmetic, but I would suggest renaming `*_configkey_*` to `*_config_key_*`. -...

@insatomcat what about the similar task in `site-container.yml.sample` ?

after discussing this with @clwluvw , we came up with the idea that maybe creating a variable `ceph_group_name` that would default to "all" (`ceph_group_name: all`) could be a decent approach...

the issue with not using `all` is that it would break the playbook execution when using the `--limit` option.

> > the issue with not using `all` is that it would break the playbook execution when using the `--limit` option. > > how so ? for instance, if you...

you shouldn't submit PRs against stable branches directly