requests_oauth2client icon indicating copy to clipboard operation
requests_oauth2client copied to clipboard

add new DPoPTokenSerializer class for [de]serializing DPoPToken

Open snarfed opened this issue 5 months ago • 3 comments

for guillp#122

@guillp one note here: this duplicates the existing code in AuthorizationRequestSerializer for [de]serializing DPoPKey. would you want a new DPoPKeySerializer class for that? I wasn't sure if you'd care more about the code duplication or the serializer class sprawl. I'm ok either way.

snarfed avatar Jul 09 '25 23:07 snarfed

Codecov Report

:x: Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review. :white_check_mark: Project coverage is 99.94%. Comparing base (49f0739) to head (69e6107). :warning: Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
requests_oauth2client/dpop.py 95.45% 1 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##              main     #174      +/-   ##
===========================================
- Coverage   100.00%   99.94%   -0.06%     
===========================================
  Files           20       20              
  Lines         1974     1995      +21     
===========================================
+ Hits          1974     1994      +20     
- Misses           0        1       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jul 09 '25 23:07 codecov[bot]

@guillp friendly ping? I'd love to get back to using requests_oauth2client from upstream here instead of my fork!...but I need this PR first.

snarfed avatar Jul 31 '25 18:07 snarfed

Hi @snarfed . This is not forgotten. But I didn't like to create 1 serializer class per token type. So I just started to refactor and improves all serializers in #196.

guillp avatar Sep 10 '25 09:09 guillp

closing this since #196 implements serialization of DPoPTokens

guillp avatar Dec 08 '25 20:12 guillp