cprior icon indicating copy to clipboard operation
cprior copied to clipboard

Published 20 hours ago • verified publisher icon guillermo-navas-palencia

Add force_termination parameter

Open idoadiv opened this issue 3 years ago • 4 comments

idoadiv avatar Sep 12 '21 10:09 idoadiv

The PR looked good. Any reason for closing it?

guillermo-navas-palencia avatar Sep 13 '21 10:09 guillermo-navas-palencia

It was closed by mistake

idoadiv avatar Sep 13 '21 12:09 idoadiv

Are you waiting for something in order to merge this?

idoadiv avatar Sep 19 '21 13:09 idoadiv

Yes. Force termination is not properly documented, and should not be passed as a dict key of data. In addition, this behaviour could be obtained outside the class. Therefore, this needs to be changed before merging. The amendments for darwin are both alright.

guillermo-navas-palencia avatar Sep 19 '21 16:09 guillermo-navas-palencia