Garlic.js icon indicating copy to clipboard operation
Garlic.js copied to clipboard

Doesn't bode well with Bootstrap 3

Open nijikokun opened this issue 11 years ago • 2 comments

Garlic.js fails when it comes to radio buttons, they don't get fired for the onRetrieve (Required to set active on Button Groups to show which radio button is active) event as far as my knowledge is and it doesn't clear any existing ones before checking the one it needs to (the attribute at least).

Doesn't fire jQuery change event either...

nijikokun avatar Nov 27 '13 02:11 nijikokun

https://github.com/bucha/Garlic.js/commit/8deecab1e81cc874b0083447779f02485b3a6508

is for reference that someone else also had this problem.

nijikokun avatar Nov 27 '13 18:11 nijikokun

Hi.

Thanks for opening this issue! Could you try to put the listener call

this.options.onRetrieve( this.$element, storedValue ); (L170)

at line 152, before checkbox and radio test ?

if ( this.$element.is( 'input[type=radio], input[type=checkbox]' ) ) {

And tell me if that works for you. If so, I'll release a patch.

Best

guillaumepotier avatar Nov 28 '13 14:11 guillaumepotier