Guilherme Leobas

Results 187 comments of Guilherme Leobas

Thanks @stuartarchibald, I'll check the test failure.

@stuartarchibald, this is a new impl. of `np.where` that works with broadcast arrays. You can ignore the diff as none of the old code was actually used.

> @guilhermeleobas, there's a conflict with mainline Fixed!

@louisamand, a patch containing the fix is still under review

@salmanulfarzy The file linked by @webknjaz has a [WTFPL](http://www.wtfpl.net/) license and oh-my-zsh is MIT-licensed. Can I just copy and paste that file into spaceship-prompt?

@salmanulfarzy, I think it's best to not truncate the last dir, just like what fish shell does. Also, I didn't get what the variables you mentioned are supposed to do....

Hi all, @salmanulfarzy, I wasn't aware of the existence of such variables. Also, I tend to agree with @maximbaz. The way `dir` is coded today makes `SPACESHIP_DIR_TRUNC` and `SPACESHIP_DIR_TRUNC_REPO` mutually...

@kc611 @stuartarchibald, would you folks be ok with not supporting `None` inputs in this patch? And instead raise an error when `x` or `y` is `None`. The current approach fails...

@stuartarchibald, the current issue happens due to how `scope.make_temp` works. It uses the length of `scope.localvars` as a name suffix for the temporary variable. So, if two scopes have the...