Guilherme G. M.

Results 30 comments of Guilherme G. M.

I think this issue is now solved? we have got HTTP emblems and other HTTP features (not all of them, but this issue speaks specifically of guild emblems)

Closing this issue since we have Rebel changes (as keikun mentioned) and also have HTTP emblem support for a while now, if something is still missing in this part, please...

I am still experiencing this issue in 3.0.17. (macOS) Here are some things I've observed: 1. The issue seems related to NPM v10 combined with installing from NPM Registry; 2....

Uhh... I am really confused now. CI is failing because httpsample registers packets below MIN_PACKET_DB: ```C addProxyPacket(API_MSG_SAMPLE_LOGIN /* 20 < 36 */, sample_login_request, sample_login_api_packet, hpProxy_ApiLogin); ``` But looking at the...

the issue with making it optional and defaulting to true is that we will break any custom script that actually expects it to stay open (like scripts that uses cutins...

I do consider a breaking change anything that requires a code change. But I don't think we should be against breaking changes, but when needed, we should safely break (as...

not sure if it helps, but I remember I had an issue where using jest's fake timers would prevent mongo operations from running and cause issues. my solution was to...

> Probably unrelated to this PR, but there's one more issue wherein API server is called for autotraders on restart, and we get bunch of Account not online errors Yeah,...

@vBrenth can you try using the first commit only? this one: https://github.com/HerculesWS/Hercules/pull/3304/commits/29d858c70589fdb8a3279d930103a43b8cc7d6c7 I am wondering if I may have made a mistake when converting to struct.

> @guilherme-gm I've been running the first commit only and its still having some saving problem but less and no disconnection between char and login so far. Thanks for the...