react-form-builder icon indicating copy to clipboard operation
react-form-builder copied to clipboard

Feat/multiple choices with columns

Open totegsito opened this issue 3 years ago • 3 comments

Type:

  • [ ] CI/CD: helm, docker & CI/CD adjustments.
  • [x] feature: new capabilities.
  • [ ] fix: bug, hotfix, etc.
  • [ ] refactor: enhancements.
  • [ ] style: changes in styles.
  • [ ] other: docs, tests.

What's the focus of this PR:

Add a new option for multiple checkboxes that allows to set up the number of numbers that will be rendered.

How to review this PR:

Play with the example updating the name of columns in the multiple checkbox element

Before submitting this PR, I made sure:

  • [X] There is no lint error in the code
  • [X] Build process passes successfully
  • [ ] There are some tests

totegsito avatar Nov 08 '21 16:11 totegsito

It would be cool if you could make some unit testing to this feature but LGTM

How could we test this? This new feature is just visual, no output is updated here 😬

totegsito avatar Nov 11 '21 11:11 totegsito

LGTM Then 😢 sorry nice job 😄

ardguezsoc avatar Nov 17 '21 17:11 ardguezsoc

There is some conflicts @totegsito

ismaelocaramelo avatar Nov 18 '21 16:11 ismaelocaramelo