Terminal.Gui icon indicating copy to clipboard operation
Terminal.Gui copied to clipboard

Force 16 colors doesn't provide visual effect to MenuBar.

Open BDisp opened this issue 1 year ago • 3 comments

@tig I don't know how you want to fix this and I'll leaving this for you.

WindowsTerminal_VNLx0Akt4a

BDisp avatar Sep 25 '24 16:09 BDisp

Yeah. Good call out.

I'm not sure what the right approach is to deal with this.

tig avatar Sep 25 '24 17:09 tig

Yeah. Good call out.

I'm not sure what the right approach is to deal with this.

I think the best approach is having two configuration, one for true color and other for 16 colors. If driver doesn't support true color then fallbacks to the 16 colors, which can't have a variant of the same color.

BDisp avatar Sep 25 '24 18:09 BDisp

Yeah. Good call out. I'm not sure what the right approach is to deal with this.

I think the best approach is having two configuration, one for true color and other for 16 colors. If driver doesn't support true color then fallbacks to the 16 colors, which can't have a variant of the same color.

That might work, but then we'd have to figure out how to auto select it.

I think this can be fixed by making CalculateColorDistance smarter.

tig avatar Sep 25 '24 20:09 tig

Fixed.

tig avatar Jun 12 '25 13:06 tig