Terminal.Gui
Terminal.Gui copied to clipboard
Views must not blindly return `true` from `Command` functions
I discovered this as I've beefed up how keyboard nav works in #3627.
Examples:
-
ListView
- blindly returnstrue
fromMoveUp/MoveDown
even if the selection was not changed (e.g.MoveUp
when at the top of the list). As a result, pressing Up when at the top of the list does not allow keyboard nav to change focus to the "previous view". -
TableView
- blindly returnstrue
from all relevant Command handlers. No arrow keys work to move to next/prev view. In addition,TableView
always returntrue
from theCommand.Accept
handler. This prevents the default button in a Dialog from working when a TableView is used.
I will be adding an all-views test in #3627 that highlights any view that behaves improperly here...