Terminal.Gui icon indicating copy to clipboard operation
Terminal.Gui copied to clipboard

Analyzers project builds with warnings

Open tig opened this issue 1 year ago • 2 comments

@dodexahedron can you please fix all the warnings?

4>------ Build started: Project: Terminal.Gui, Configuration: Debug Any CPU ------
2>C:\Program Files\dotnet\sdk\8.0.300-preview.24203.14\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.RuntimeIdentifierInference.targets(311,5): message NETSDK1057: You are using a preview version of .NET. See: https://aka.ms/dotnet-support-policy
3>C:\Users\Tig\s\gui-cs\Terminal.Gui\Analyzers\Terminal.Gui.Analyzers.Internal.Tests\Generators\EnumExtensions\EnumDefinitions\WithGenerator\BetterEnum_ExplicitInt_NoFastIsDefined.cs(44,5,44,10): warning CA1707: Remove the underscores from member name Terminal.Gui.Analyzers.Internal.Tests.Generators.EnumExtensions.EnumDefinitions.BetterEnum_ExplicitInt_NoFastIsDefined.All_0 (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707)
3>C:\Users\Tig\s\gui-cs\Terminal.Gui\Analyzers\Terminal.Gui.Analyzers.Internal.Tests\Generators\EnumExtensions\EnumDefinitions\WithGenerator\BetterEnum_ExplicitInt_NoFastIsDefined.cs(46,5,46,19): warning CA1707: Remove the underscores from member name Terminal.Gui.Analyzers.Internal.Tests.Generators.EnumExtensions.EnumDefinitions.BetterEnum_ExplicitInt_NoFastIsDefined.Alternating_01 (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707)
3>C:\Users\Tig\s\gui-cs\Terminal.Gui\Analyzers\Terminal.Gui.Analyzers.Internal.Tests\Generators\EnumExtensions\EnumDefinitions\WithGenerator\BetterEnum_ExplicitInt_NoFastIsDefined.cs(45,5,45,10): warning CA1707: Remove the underscores from member name Terminal.Gui.Analyzers.Internal.Tests.Generators.EnumExtensions.EnumDefinitions.BetterEnum_ExplicitInt_NoFastIsDefined.All_1 (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707)
3>C:\Users\Tig\s\gui-cs\Terminal.Gui\Analyzers\Terminal.Gui.Analyzers.Internal.Tests\Generators\EnumExtensions\EnumDefinitions\WithGenerator\BetterEnum_ExplicitInt_NoFastIsDefined.cs(47,5,47,19): warning CA1707: Remove the underscores from member name Terminal.Gui.Analyzers.Internal.Tests.Generators.EnumExtensions.EnumDefinitions.BetterEnum_ExplicitInt_NoFastIsDefined.Alternating_10 (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707)
3>C:\Users\Tig\s\gui-cs\Terminal.Gui\Analyzers\Terminal.Gui.Analyzers.Internal.Tests\Generators\EnumExtensions\EnumDefinitions\WithGenerator\BetterEnum_NoFastIsDefined.cs(43,5,43,10): warning CA1707: Remove the underscores from member name Terminal.Gui.Analyzers.Internal.Tests.Generators.EnumExtensions.EnumDefinitions.BetterEnum_NoFastIsDefined.All_0 (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707)
3>C:\Users\Tig\s\gui-cs\Terminal.Gui\Analyzers\Terminal.Gui.Analyzers.Internal.Tests\Generators\EnumExtensions\EnumDefinitions\WithGenerator\BetterEnum_NoFastIsDefined.cs(44,5,44,10): warning CA1707: Remove the underscores from member name Terminal.Gui.Analyzers.Internal.Tests.Generators.EnumExtensions.EnumDefinitions.BetterEnum_NoFastIsDefined.All_1 (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1707)
3>C:\Users\Tig\s\gui-cs\Termin
...

tig avatar May 09 '24 22:05 tig

Looks like the naming rules themselves need to be fixed, because that CA1707 shouldn't be happening.

Easy enough. I don't receive it, so I must have accidentally suppressed it somewhere on my environment.

I've been meaning to turn some existing ones up a notch anyway, so I'll fix 'em after I do the build doc stuff (that's partially written already).

dodexahedron avatar May 10 '24 00:05 dodexahedron

I'm going to try out the doc processor/formatter thing that Microsoft suggests for PowerShell code that already has get-help metadata. I've never used it myself, since it's never really come up internally, but apparently it's what they use to generate theirs, too, so it should have some really nice results if that's actually the case.

That's for generating API documentation style stuff.

The README.md in both the Scripts folder and the repo root are both getting necessary steps for quick-start build instructions, of course, and the one in the Scripts folder is getting a ton more default, assuming basically 0 PowerShell experience. Aside from launching it, I guess. But if they can't figure out how to launch PowerShell and navigate around a CLI, they're gonna have a tough time with building and consuming a dll project for creating TUIs. 😅

dodexahedron avatar May 10 '24 00:05 dodexahedron