CacheP2P icon indicating copy to clipboard operation
CacheP2P copied to clipboard

Published 20 hours ago • verified publisher icon guerrerocarlos

Tests?

Open zeke opened this issue 8 years ago • 2 comments

This project looks pretty cool! Does it have tests? The package.json suggests that it does, but I don't see any test files...

https://github.com/guerrerocarlos/CacheP2P/blob/ac03daa4d29cbcd930952693daa960a56bbd78ec/package.json#L66-L69

zeke avatar Oct 23 '16 04:10 zeke

Yep, still doesn't have any tests :(

I know tests are super important, any contributor that could help with creating and adding them, it would be greatly appreciated, I can't add them myself for now.

guerrerocarlos avatar Oct 23 '16 11:10 guerrerocarlos

It looks like the test runner mentioned in the test script is zuul, which should be good for unit testing the constructor and events. Not sure what unit testing library you prefer. Jasmine has been great to work with.

It would be nice to have integration tests that spin up a static server and multiple browser clients, then makes assertions about how many requests actually hit the server. Selenium seems like a good fit.

deckar01 avatar Oct 24 '16 19:10 deckar01