pls-cli icon indicating copy to clipboard operation
pls-cli copied to clipboard

Feature choose language

Open alonmar opened this issue 1 year ago • 5 comments

This issue added in doc #21

  • 💡Added command to choose the language of quotes
  • 💡Translate quotes to spanish
  • 💡Moved quotes to new folders according to language
  • 💡Added test language command
  • 💡Default language is english

I tried to copy as much as possible to your coding/commit style, I await your comments 👀

alonmar avatar Aug 01 '22 07:08 alonmar

I don't know if this is the best way to have the translations, I was thinking of leaving the translations out of the python package to keep the package smaller and if the user wants a specific translation, the CLI would download the translation and put it inside the folder of configuration.

Today we only have two languages, but in the future we may have several and this can increase the size of the package and not everyone needs to have all the translations by default.

What do you think?

guedesfelipe avatar Aug 01 '22 22:08 guedesfelipe

To fix the linting you can run the make format command 😃

guedesfelipe avatar Aug 01 '22 22:08 guedesfelipe

Yeah, I think it is better to keep it to a minimum, so can we continue with my PR for the moment which is 2 languages (i am fixed the linting), and start looking for an option to increase the number of languages?

alonmar avatar Aug 02 '22 15:08 alonmar

I think it's better to do the final solution to avoid problems with future versions.

I thought of having a folder called translations at the root of the project and inside it containing the folders or just the files with the translated quotes. In the CLI, have a command that lists the possible translations and downloads from this location to the config folder of the PLS-CLI and configures the default language within the configuration file.

guedesfelipe avatar Aug 03 '22 01:08 guedesfelipe

-💡Moved quotes location -💡Remove language selection from setup command -💡Add the command and function that lists the languages

alonmar avatar Aug 04 '22 03:08 alonmar