Dickson S. Guedes
Dickson S. Guedes
> This is super cool! Nice! Thank you! > Let me know if you'd like me to merge this as is, or you'd like to keep working on it. Let...
> * limit how many pools are listed, with a search function; some configs in multi-tenant situations can get very long. Yeah! It would be nice to have some search...
Hi @levkk! > More things I think would be cool to implement as well: > > * show the values from `General` config, e.g. timeouts, port, host, etc. I cleaned...
Once checks passes and unless you have objections, the code is ready to merge. :blue_heart:
> Hey @guedes , sorry for a late reply. One last nit pick before we can merge: could you make the general stats be a vertical table? As you mentioned,...
Hi @levkk! Done! This is good for you? ``` cargo run -- config show Finished dev [unoptimized + debuginfo] target(s) in 0.07s Running `target/debug/pgcat config show` 2023-08-18T22:00:57.034616Z INFO pgcat: Welcome...
> LGTM! Let me know if you'd like me to merge. Yes! Thank you!
Hi @levkk! I just rebased and squashed commits. Now waiting for circleci check to pass. Once test passes this PR could be merged. I'll work on other features in separated...
I'll poke into that. Thanks!
Thanks! I'm working on 11 support.