eclipse-ui-theme icon indicating copy to clipboard operation
eclipse-ui-theme copied to clipboard

Theme is forcing editor's background color to #262626

Open josephknight opened this issue 11 years ago • 8 comments

Is there a way to edit the css to not make any ide background changes until a fix is provided? I'm using custom syntax coloring (as I'm sure many do) and the theme is overriding my background color that was chosen in General>Editors>Text Editors>Background Color.

If I set this to something else and back (by checking/unchecking system default) I see my color return. But as soon as I hit OK we're back to moonrise's forced background.

I tried commenting all lines containing #262626 in all css files and recompressing the jar but I didn't get any results.

josephknight avatar Jan 15 '14 18:01 josephknight

If I remember it correctly you need to change the value for

#org-eclipse-e4-ui-compatibility-editor Canvas,
#org-eclipse-e4-ui-compatibility-editor Canvas > *,
#org-eclipse-e4-ui-compatibility-editor Canvas > * > * { ... }

and

CTabFolder Canvas { ... }

I had to force it in order to bypass multiple Eclipse bugs with the editor view, otherwise background color for line number column will not use the same color of the background of the code area, the same happens with the column with the arrows to fold/unfold code if you use CDT and with its edges.

You need to change them in any of the CSS file (stylesheets are copy pasted because of another Eclipse bug with @import), if you're using only OSX then you can modify only the OSX stylesheets.

guari avatar Jan 15 '14 21:01 guari

Eclipse 4.4 final release should provide a way to handle the values set in preferences setting as constants into CSS, so it should be easy to automatically merge the two things.

guari avatar Jan 15 '14 21:01 guari

Tried with no effect. I do CSS for a living and still cant make it work... likely I'm doing something wrong with the files.

Also, perhaps there's more reason than this:

I had to force it in order to bypass multiple Eclipse bugs with the editor view, otherwise background color for line number column will not use the same color of the background

...to remove users ability to choose their IDE background color (I argue one of the top 2 most important colors to be customizable by the user), but from my limited knowledge it seems that this trade-off for the sake of matching the line number column is simply not worth it.

I'm so close to being able to use this theme, it's just not currently manageable for Mac users with their own favorite syntax highlighting scheme. That's a large group.

Best wishes, I hope your theme's concepts are adopted soon.

josephknight avatar Jan 15 '14 21:01 josephknight

Eclipse 4.4 final release should provide a way to handle the values set in preferences setting as constants into CSS, so it should be easy to automatically merge the two things.

That's good news.

josephknight avatar Jan 15 '14 21:01 josephknight

Before forcing it, many user complained with the other issue with line number, folding and editor edges that generated artifacts.. :) There are already many artifacts due to other Eclipse bugs so I put it in that way to reduce the visual glitches out-of-the-box. Anyway try your changes with a new workspace and/or a clean Eclipse install folder, it sometimes caches resources.

guari avatar Jan 15 '14 21:01 guari

Was there ever a resolution to this problem of not being able to override the default background color? I'm attempting to upgrade to Luna, and being able to set the background to pure black is the last hurdle (this is possible with my current Kepler settings).

tjvanpat avatar Aug 18 '14 21:08 tjvanpat

@tjvanpat BTW, it is better not to upgrade to Luna, but download zip and set it up by side as second Eclipse

paulvi avatar Aug 19 '14 10:08 paulvi

@PaulVI Well, yes, I agree and that's what I'm doing. I'm attempting to set up my plugins to match my current Kepler settings, and this last UI tweak is all that's left, since I haven't found a workaround yet that allows me to override the default setting.

tjvanpat avatar Aug 19 '14 16:08 tjvanpat