monkey icon indicating copy to clipboard operation
monkey copied to clipboard

765 add cypress

Open cakekoa opened this issue 1 year ago • 1 comments

What does this PR do?

Fixes #765.

Add any further explanations here.

PR Checklist

  • [ ] Have you added an explanation of what your changes do and why you'd like to include them?
  • [ ] Is the TravisCI build passing?
  • [ ] Was the CHANGELOG.md updated to reflect the changes?
  • [ ] Was the documentation framework updated to reflect the changes?
  • [ ] Have you checked that you haven't introduced any duplicate code?

Testing Checklist

  • [ ] Added relevant unit tests?
  • [ ] Do all unit tests pass?
  • [ ] Do all end-to-end tests pass?
  • [ ] Any other testing performed?

    Tested by {Running the Monkey locally with relevant config/running Island/...}

  • [ ] If applicable, add screenshots or log transcripts of the feature working

cakekoa avatar Jan 31 '24 18:01 cakekoa

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.46%. Comparing base (cbdc632) to head (c976e78).

:exclamation: Current head c976e78 differs from pull request most recent head c4001ac. Consider uploading reports for the commit c4001ac to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4048      +/-   ##
===========================================
+ Coverage    77.41%   77.46%   +0.04%     
===========================================
  Files          453      453              
  Lines        14377    14406      +29     
  Branches        18       18              
===========================================
+ Hits         11130    11159      +29     
  Misses        3247     3247              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 31 '24 18:01 codecov[bot]

Overall I like Cypress. I think component tests will be pretty much useless for us, but E2E would be valuable. The problem is scope. Cypress needs to be integrated or should even replace our E2E tests. For now we should focus on UI refactoring effort, which means rewriting the UI with a global store, MUI and next.js. Once that is done we can look into rewriting our E2E infrastructure, but ATM I think it's best to not grow the scope of an already massive effort

VakarisZ avatar Mar 04 '24 12:03 VakarisZ

Couldn't remove typescript for now and I don't want to spend a lot of time on it, so lets keep it.

VakarisZ avatar Mar 04 '24 16:03 VakarisZ