orbot icon indicating copy to clipboard operation
orbot copied to clipboard

java.util.ConcurrentModificationException: in TorControlConnection

Open n8fr8 opened this issue 3 years ago • 2 comments

Stack trace Occurrence 1 of 1,639 Crash brightness_1 Samsung Galaxy S22 Ultra brightness_1 Android 12 (SDK 31) brightness_1 1660300402.apk brightness_1 9 minutes ago Type java.util.ConcurrentModificationException java.util.ConcurrentModificationException: at java.util.ArrayList$Itr.next (ArrayList.java:860) at net.freehaven.tor.control.TorControlConnection.handleEvent (TorControlConnection.java:239) at net.freehaven.tor.control.TorControlConnection.react (TorControlConnection.java:382) at net.freehaven.tor.control.TorControlConnection$ControlParseThread.run (TorControlConnection.java:352)

n8fr8 avatar Mar 18 '22 17:03 n8fr8

Was there anything specific happening when you encountered this crash?

bitmold avatar Mar 19 '22 03:03 bitmold

Technically this is happening in Tor-Android, I'm still going to debug it though:

    protected void handleEvent(ArrayList<ReplyLine> events) throws UnsupportedOperationException {
        if (handler == null && rawEventListeners.isEmpty()) {
            return;
        }

        for (Iterator<ReplyLine> i = events.iterator(); i.hasNext(); ) {
            ReplyLine line = i.next();
            int idx = line.msg.indexOf(' ');
            String tp;
            String rest;
            try {
                tp = line.msg.substring(0, idx).toUpperCase();
                rest = line.msg.substring(idx + 1);
            } catch (StringIndexOutOfBoundsException ex) {
                throw new UnsupportedOperationException(
                        "Event listened for is not yet implemented" , ex
                );
            }
...

CC'ing @eighthave

bitmold avatar Mar 19 '22 03:03 bitmold