orbot icon indicating copy to clipboard operation
orbot copied to clipboard

FullPerm App Uses Orbot TV in FileName

Open sisbell opened this issue 3 years ago • 1 comments

Looks like a regression after introducing new flavors. Latest tag is orbot TV so its being using in the full perm apk

  • Orbot-orbot-tv-1.0.0-BETA-2-tor-0.4.5.9-7-g92693d66-fullperm-arm64-v8a-debug.apk
  • Orbot-orbot-tv-1.0.0-BETA-2-tor-0.4.5.9-7-g92693d66-fullperm-armeabi-v7a-debug.apk
  • Orbot-orbot-tv-1.0.0-BETA-2-tor-0.4.5.9-7-g92693d66-fullperm-x86-debug.apk
  • Orbot-orbot-tv-1.0.0-BETA-2-tor-0.4.5.9-7-g92693d66-fullperm-x86_64-debug.apk

% git describe --tags --always -> orbot-tv-1.0.0-BETA-2-tor-0.4.5.9-8-g5f45f0ac

sisbell avatar Aug 02 '21 17:08 sisbell

I believe this would fix the issue:

git describe --tags --always --match "1*" since all of the current versions start with 16

16.5.1-BETA-2a-tor.0.4.5.9-24-g5714c443

But a better solution may be to start the tags something like "orbot-app-" so its consistent with the rest of the tags. And then we can just do

git describe --tags --always --match "orbot-app*"

sisbell avatar Aug 06 '21 18:08 sisbell