guardianproject
Orbot Authentication Corner Cases and Bug Fixes
- Fixes #1325 where the password lock would crash on APIs lower than 30. This is done by forcing biometrics OR password for those devices
- Nougat, and some other older Androids, would enter a loop with the old code for prompting authentication (once the aforementioned crash was fixed). This fixes #1340
- Adds a preference on API >= 30 to disallow biometrics, forcing user to only use password
- Fixes some edge cases where user has no authentication setup
- Updates UI to be focused more on "Authentication" instead of passwords since biometrics are also now enabled.
Answered this off thread, but yes there is no case of the user being locked out of the app forever. If they disable their device passcode and then continue to use Orbot with this feature enabled Orbot will just display a Toast saying please set a passcode in order to use the authentication feature
When I open Orbot and get the authentication screen and select "Cancel", then the next time I open Orbot, the authentication screen is not displayed and I can enter Orbot with no authentication.
I can't reproduce on Nougat which actually has a cancel button, or on Android 34 which does not. What version are you using?
I can't reproduce on Nougat which actually has a cancel button, or on Android 34 which does not. What version are you using?
I am testing with Nougat using a pattern lock.
Thanks for looking, based on the logic I suspect this should fix it, but I'm still unable to reproduce it :woman_shrugging:
Thanks for looking, based on the logic I suspect this should fix it, but I'm still unable to reproduce it 🤷♀️
Its fixed now, thanks!.
Oh my mistake, I had commented on my phone and didn't realize that this became no longer mergeable after I added a string resource last night. Taken care of.
Merging because only pending change was a method rename, and to get new string resources added to localization service.