haven icon indicating copy to clipboard operation
haven copied to clipboard

Migrate Date Pickers to official

Open fat-tire opened this issue 4 years ago • 2 comments

I haven't tried it yet but maybe switch from

implementation 'com.wdullaer:materialdatetimepicker:4.2.3'

to the official MaterialTimePicker.

It's had changes as recently as a few days ago, but if someone wants me to try it I can. Just checking interest.

fat-tire avatar Aug 03 '20 22:08 fat-tire

I think the library we are using is a little more customizable, although I am not aware if we are using these customizations.

archie94 avatar Aug 04 '20 11:08 archie94

.02 - I'd vote to leave this out until the major pain points are worked out.

Reasoning: it works & has no open issues for date/time selection with this codebase. Localization and date-time formats currently stable.

UI needs a proper refresh when functionality hits an acceptable mark.

A few that come to mind:

  • Onboarding Sensor Layout
  • Settings
  • Enhanced Signal setup
  • Status glyphs for server & HB
  • Separate & customizable sensor selection for legacy/flagship devices

Open to suggestions here & future as I have more time to devote to the project. Thanks all for the continued effort.

lukeswitz avatar Aug 04 '20 13:08 lukeswitz