haven LeakCanary investigation to find memory leaks

LeakCanary investigation to find memory leaks

Open archie94 opened this issue 5 years ago • 4 comments

~~Call cameraview destroy() instead of close() on Fragment onDestroy()~~ Do the same with LifecycleOwner -> #393

destroy() releases the camera resource unlike close() which just stops the preview (Seems to fix #393 #394 #392 #391 )

Apr 21 '19 10:04 archie94

Some major leaks around Camera, Settings, Signal and MaterialDateTime Picker fixed. Please test once and consider merging.

May 14 '19 17:05 archie94

Merged fine, and is not crashing, but seem to not be capturing all the camera positive detect events. Will dig and test some more.

May 29 '19 18:05 n8fr8

Definitely something different happening with logging events. Master works fine, but this PR seems to not be persisting matched events.

May 29 '19 20:05 n8fr8

:/ Will check it out! Meanwhile if you feel it is happening for any specific scenario or find any steps to reproduce do leave them here.

I hope these event / event triggers are solely around the camera?

Thanks for the testing!

May 29 '19 21:05 archie94