source icon indicating copy to clipboard operation
source copied to clipboard

Make BackToTop an explicit export from source-react-components

Open i-hardy opened this issue 3 years ago • 2 comments

What is the purpose of this change?

This fixes an issue with importing the BackToTop component in the dev kitchen FooterWithContents component.

What does this change?

  • Make BackToTop an explicit export of @guardian/source-react-components
  • Import it directly from the package in FooterWithContents

i-hardy avatar Sep 02 '22 12:09 i-hardy

🦋 Changeset detected

Latest commit: e35777200f007fc43809f963fe8a2b8bc8793f86

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@guardian/source-react-components Minor
@guardian/source-react-components-development-kitchen Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Sep 02 '22 12:09 changeset-bot[bot]

as it's a new export, could you add a story for it?

sndrs avatar Sep 02 '22 15:09 sndrs

Hey @sndrs, if you have some time to take a look at this today I'd really appreciate it, this is becoming a blocker.

i-hardy avatar Sep 06 '22 12:09 i-hardy

apologies @i-hardy – looks great! thanks for the changes 👍

sndrs avatar Sep 06 '22 12:09 sndrs