source icon indicating copy to clipboard operation
source copied to clipboard

Use Source's ESLint plugins in Source

Open SiAdcock opened this issue 2 years ago • 1 comments

What is the purpose of this change?

There are compelling reasons to dogfood our own ESLint plugins:

  • ensure Source is conforming to the standards and rules we place on its consumers
  • make it easier to ensure these plugins are working as expected

What does this change?

  • Add @guardian/eslint-plugin-source-foundations and @guardian/eslint-plugin-source-react-components to ESLint config

SiAdcock avatar Jun 23 '22 06:06 SiAdcock

⚠️ No Changeset found

Latest commit: 569e93f6ae9dd73883c593cfbd194e33e688a5d5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jun 23 '22 06:06 changeset-bot[bot]

Does anyone have any objections to this being merged as it is? @sndrs @ob6160 @tjsilver

joecowton1 avatar Oct 24 '22 11:10 joecowton1

Does anyone have any objections to this being merged as it is? @sndrs @ob6160 @tjsilver

none from me

ob6160 avatar Oct 24 '22 11:10 ob6160

did we resolve the issue of needing to build these eslint configs now before being able to lint?

sndrs avatar Oct 24 '22 13:10 sndrs

did we resolve the issue of needing to build these eslint configs now before being able to lint?

no, this was missed — i'll raise a followup PR that ensures the build step happens before linting locally

ob6160 avatar Oct 24 '22 14:10 ob6160