grid
grid copied to clipboard
fixing myUploads bugs
What does this change do?
The BBC introduced a new set of controls - permissions filter, show payable images, sort control and my uploads - written in react to display in a second tier toolbar at the top of the page when the kahuna config variable usePermissionsFilter is set yo true. It's been found that problems with the interop between AngularJS and React have introduced some regressions to the system functionality (along with some missed specifications). This PR corrects these regressions whilst ensuring continuing operation when permisisons filter is off.
Areas impacted:
- clicking the logo button should clear the filter and set the 'Show Payable Images' control in-line with user type - on for Archivists and off for standard users
- selecting My Uploads control show turn show payable images on so that any user uploaded images without a rights category are also shown. Unchecking the control should turn show payable images off (this was missed specification and so is new functionality)
- selecting 'View All Your Uploads' from the uploads page should return to the search page and set 'show payable images' to on along with the 'my uploads' control checked
- use of logo or search from uploads page should return to search page with clear search (this is the default url /search)
- use of back button from uploads page of image view should return to search page with search retained.
- when pasting urls into a browser tab all controls should be set to match the values in the url
View of permissions filter layout:
Behaviour of system with permissions filter off should be unaltered. View of permissions filter off;
How should a reviewer test this change?
Ensure that all the impacted functional areas behave as expected and described.
Who should look at this?
Tested? Documented?
- [x] locally by committer
- [ ] locally by Guardian reviewer
- [ ] on the Guardian's TEST environment
- [ ] relevant documentation added or amended (if needed)