grid icon indicating copy to clipboard operation
grid copied to clipboard

use testcontainers directly instead of docker-testkit

Open andrew-nowak opened this issue 1 year ago • 1 comments

What does this change?

@Conalb97 raised that docker-testkit has some sort of incompatibility with M1 macs on certain JDKs. docker-testkit isn't receiving maintenance updates, and neither is the underlying docker client, so this is a good opportunity to replace it with a direct usage of testcontainers (mainly taking inspiration from Ophan https://github.com/guardian/ophan/blob/2ecb80da40915ce097e4a1de0e29b352b396323e/shared-lib/src/test/scala/app/BaseElasticTest.scala#L153 though we share the container between the tests, instead of a container per test, for a mild performance boost)

andrew-nowak avatar Jan 26 '24 15:01 andrew-nowak

I can see nothing that would present a problem for BBC devs. Thanks

AndyKilmory avatar Jun 19 '24 11:06 AndyKilmory

I had a similar issue with path-manager, which I fixed in https://github.com/guardian/path-manager/pull/61 by adding an explicit dependency on a newer version of jnr-unixsocket

davidfurey avatar Jun 20 '24 09:06 davidfurey

I had a similar issue with path-manager, which I fixed in guardian/path-manager#61 by adding an explicit dependency on a newer version of jnr-unixsocket

Thanks that's a good find! However the docker lib is still unmaintained and these sorts of problems are gonna continue ramping up - so I think it's still worth replacing with the fresher/slimmer lib

andrew-nowak avatar Jun 20 '24 11:06 andrew-nowak

I had a similar issue with path-manager, which I fixed in guardian/path-manager#61 by adding an explicit dependency on a newer version of jnr-unixsocket

Thanks that's a good find! However the docker lib is still unmaintained and these sorts of problems are gonna continue ramping up - so I think it's still worth replacing with the fresher/slimmer lib

Seems reasonable. If you were feeling keen and wanted to apply the same approach to path-manager, I'd be very grateful.

davidfurey avatar Jun 20 '24 12:06 davidfurey

Seen on auth, usage, metadata-editor, thrall, leases, cropper, collections, media-api, kahuna (merged by @andrew-nowak 9 minutes and 36 seconds ago) Please check your changes!

prout-bot avatar Jun 20 '24 12:06 prout-bot

Seen on image-loader (merged by @andrew-nowak 9 minutes and 48 seconds ago) Please check your changes!

prout-bot avatar Jun 20 '24 12:06 prout-bot