Imagedam 1289 - editing multiple domain metadata

[abdelrahmansd]

What does this change?

enable adding and editing multiple images domain metadata fields

How should a reviewer test this change?

when selecting multiple images, the user can add or update the domain metadata field for all selected images

How can success be measured?

Who should look at this?

Tested? Documented?

• [x] locally by committer
• [ ] locally by Guardian reviewer
• [ ] on the Guardian's TEST environment
• [ ] relevant documentation added or amended (if needed)

[paperboyo]

Hi, sorry, it took so long! Testing this in our TEST env., I find that given two images and below config.

Domain Metadata config:

domainMetadata.specifications = [
  {
    name = "andrewspec"
    label = "Andrews domain metadata"
    description = "For testing"
    fields = [
      {
        name = "andrewfield"
        label = "andrews field"
        type = "string"
      },
      {
        name = "andrewselect"
        label = "andrews select field"
        type = "select"
        options = [ "opt a", "opt b" ]
      }
    ]
  }
]

Image A: andrewfield: dupa, andrewselect: unset Image B: andrewfield: empty, andrewselect: opt. a

When I select both images, Domain Metadata is nicely batch-editable, but for these small problems which are not existing for other fields:

1. When I try to batch edit andrewfield (which, correctly says Multiple andrews field (click ✎ to edit all)), and I enter editing after starting a selection from image A, the editing field is prepopulated with dupa (it should be empty)
2. When I try to batch edit andrewselect, it incorrectly says Unknown (click ✎ to add), it should indicate there are values set for some images: Multiple andrews select field (click ✎ to edit all)

Also, in general:

3. When I select multiple images without anything in andrewfield (string type), the value in the Info panel doesn’t display anything. It should display Unknown (click ✎ to add)
4. Domain Metadata edits should be hooked up to the progress bar, like all other edits (and which is useful for large batches)

In general, it seems to me that pts. 1, 2 and 3 may produce incorrect results depending on what is the metadata state for the first image I click when starting a selection. Logic on what to display for empty values, conflicting values and what to prepopulate the value with when editing should never depend on how selection was constructed.

[twrichards]

@paperboyo what's the latest with this one? does it need code review yet?

[paperboyo]

does it need code review yet?

I don’t think we’ve heard about fixing the above? This is functionality we are not using, but I thought worth making sure it works correctly. But if our colleagues prefer, we can merge as is and wait for fixes in subsequent PRs? Will mention during the meeting. Here, just cc @davmacbea @AndyKilmory

[AndyKilmory]

Not work that I was aaware of - looks like Ebu was working on it. We can look to add to our schedule if required.

[honorcb]

Being able to do what this PR should enable, is wanted by the team who deal with Musical events, The are wanting to upload this pictures for these events, ( between 25 -35 per event ) and the group of images for each event have a TX date time, to add to the BBC metadata , which is very slow manually 2019 | 1Xtra Live 2019 | 6 Music Festival 2019 | Asian Network Live 2019 | BBC Music Introducing Live 2019 | Glastonbury 2019 | Radio 1's Big Weekend 2019 | Radio 2 Live in Hyde Park 2019 | Reading & Leeds 2019 | SXSW 2020 | 6 Music Festival 2020 | Proms 2020 | Radio 2 Live at Home 2021 | 6 Music Festival 2021 | R1's Out Out! Live 2021 | Radio 1's Big Weekend 2021 | Reading & Leeds 2022 | 6 Music Festival 2022 | Glastonbury 2022 | R1 Big Weekend 2022 | Reading & Leeds 2022 | Wireless Festival 2023 | 6 Music Festival 2023 | Glastonbury 2023 | Radio 1's Big Weekend 2023 | Reading & Leeds 2023 | Wireless Festival 2024 | 6 Music Festival